jannover/Untis-Logger
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 5 Packages Wiki Activity Actions

fix: Correct scheduler timing and lesson selection #4

Merged
Jannover5000r merged 1 commit from fix-scheduler-bugs into main 2025-10-27 12:23:21 +01:00
Conversation 0 Commits 1 Files changed 1 +33 -46
Jannover5000r commented 2025-10-27 12:23:12 +01:00 (Migrated from github.com)
Copy link

This commit resolves several issues with the notification scheduler:

  • DMs are no longer delayed, and notifications are sent at the correct times.
  • The lesson selection logic now correctly identifies the next lesson.
  • The Discord webhook now sends notifications reliably.

A new, robust scheduler has been implemented to prevent missed notifications due to timing drift, and the Run function has been refactored to ensure the correct lesson is always selected. Additionally, a check has been added to prevent silent webhook failures when the URL is not configured.

This commit resolves several issues with the notification scheduler: - DMs are no longer delayed, and notifications are sent at the correct times. - The lesson selection logic now correctly identifies the next lesson. - The Discord webhook now sends notifications reliably. A new, robust scheduler has been implemented to prevent missed notifications due to timing drift, and the `Run` function has been refactored to ensure the correct lesson is always selected. Additionally, a check has been added to prevent silent webhook failures when the URL is not configured.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jannover/Untis-Logger#4
No description provided.
Delete branch "fix-scheduler-bugs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?